[PLAT-7432] Fix crash in -[BSGURLSessionTracingProxy forwardInvocation:]

[nickdowell]

Goal

Fix a crash in -[NSInvocation selector] when called from -[BSGURLSessionTracingProxy forwardInvocation:] for some (malformed?) invocations that have appear to have too few arguments.

NSInvalidArgumentException: -[NSInvocation getArgument:atIndex:]: index (1) out of bounds [-1, 0]

0  CoreFoundation   -[NSInvocation getArgument:atIndex:]
1  CoreFoundation   -[NSInvocation selector]
2  AppName          -[BSGURLSessionTracingProxy forwardInvocation:] (BSGURLSessionTracingProxy.m:51:32)

Changeset

The crash is avoided by simplifying the implementation of forwardInvocation: and removing the call to -[NSInvocation selector] - which is possible because BSGURLSessionTracingProxy now implements URLSession:task:didFinishCollectingMetrics:

Testing

Unit tests have been added to ensure the forwarding logic works as intended.

Unit tests now run on CI, which required some alteration of settings and code.

[github-actions]

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,255,032 bytes

Generated by 🚫 Danger