[PLAT-7412] Improve logging around debugger being attached #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Log a less intimidating message when Bugsnag is started with a debugger attached.
The current message
[Bugsnag] [ERROR] Failed to install crash handler. No exceptions will be reported!is a little alarming and indicates that there has been an error when this is actually expected behaviour when a debugger is attached.Changeset
If a debugger is attached and autoDetectErrors was enabled, a less alarming message is now shown:
bsg_kscrashsentry_installWithContext()is now only called if crash handlers should be installed, to prevent unnecessary warnings being logged about a debugger being attached.Removed the exclamation mark from the error message for failure to install crash handlers.
Testing
Tested with example app.