Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate error class, error message and context #1501

Merged
merged 1 commit into from Nov 3, 2022

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Nov 1, 2022

Goal

Reduce number of oversized payloads due to exceeding back-end's size limit.

Follow-up to #1449

Changeset

Truncates additional strings that can potentially get long:

  • context
  • errorClass
  • errorMessage

Testing

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Bugsnag.framework binary size did not change - 706,120 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2%    +480  +0.2%    +480    __TEXT,__text
  -1.9%    -480  -1.9%    -480    [__TEXT]
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@nickdowell nickdowell marked this pull request as ready for review November 3, 2022 08:05
@nickdowell nickdowell merged commit d866ed6 into next Nov 3, 2022
@nickdowell nickdowell deleted the nickdowell/additional-truncation branch November 3, 2022 08:05
@kstenerud kstenerud mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants