fix(oom): Disable out-of-memory reporting in debug mode #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
force-pushed
the
kattrali/oom-disable-debug
branch
from
11f2423
to
da4e124
Compare
kattrali
force-pushed
the
kattrali/oom-disable-debug
branch
from
da4e124
to
d7f04ad
Compare
kattrali
force-pushed
the
kattrali/oom-disable-debug
branch
from
d7f04ad
to
7814741
Compare
tomlongridge
approved these changes
Jul 15, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Remove erroneous out-of-memory reports during development if reporting is enabled in debug mode. Since running the app via Xcode/simctl terminates the existing app launch session with a kill signal, no cleanup can be performed and the app state would indicate that a possible OOM may have occurred.
Changeset
reportOOMsif inDEBUGmode.Tests