Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Increased detail in handled event breadcrumb #493

Merged
merged 10 commits into from Mar 30, 2020
Merged

(feat) Increased detail in handled event breadcrumb #493

merged 10 commits into from Mar 30, 2020

Conversation

robinmacharg
Copy link
Contributor

Goal

Add additional metadata to handled error breadcrumbs.

Design

Simply add two additional fields to the preexisting breadcrumb metadata .

Changeset

BugsnagClient. Some small additional formatting/renaming changes were incorporated.

Tests

Unit test added.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg force-pushed the robin/add-additional-metadata-to-error-breadcrumbs branch from 2460a1d to 41a9e0f Compare March 23, 2020 13:56
@robinmacharg robinmacharg marked this pull request as ready for review March 23, 2020 13:57
tomlongridge
tomlongridge approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@tomlongridge tomlongridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor comments

Tests/BugsnagClientTests.m Outdated Show resolved Hide resolved
Tests/BugsnagClientTests.m Outdated Show resolved Hide resolved
robinmacharg and others added 2 commits March 23, 2020 19:20
@robinmacharg @tomlongridge
Update Tests/BugsnagClientTests.m
c85f565 
Co-Authored-By: Tom Longridge <tom@bugsnag.com>
@robinmacharg @tomlongridge
Update Tests/BugsnagClientTests.m
485e0e1 
Co-Authored-By: Tom Longridge <tom@bugsnag.com>
Robin Macharg added 7 commits March 27, 2020 13:24
Merge branch 'robin/Enhance-automatic-breadcrumbs-for-orientation-cha…
baac790 
…nge' into robin/add-additional-metadata-to-error-breadcrumbs

# Conflicts:
#	Source/BugsnagClient.m
(fix) Revert a change to the event serialisation that caused breadcru…
239697b 
…mbs to fail to be reported

A global search-and-replace of "name" by "message" in the breadcrumb portions of code (to bring the cocoa notifier in line with other notifiers) failed to take account of the Bugsnag error reporting API, which expects a "name"-keyed field.
Merge branch 'robin/fix-breadcrumb-error-api' into robin/add-addition…
84b6afe 
…al-metadata-to-error-breadcrumbs
post-merge fixup
8bb7c57
(fix) Additional reversion of API-breaking changes, addressed a small…
c6fe42e 
… review issue
Merge remote-tracking branch 'origin/v6' into robin/add-additional-me…
37e01e2 
…tadata-to-error-breadcrumbs
Small post-merge fixup
b7a6ea6
@robinmacharg robinmacharg merged commit 3d5639a into v6 Mar 30, 2020
@robinmacharg robinmacharg deleted the robin/add-additional-metadata-to-error-breadcrumbs branch March 30, 2020 09:43
@robinmacharg robinmacharg mentioned this pull request Mar 30, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalwrench fractalwrench fractalwrench left review comments

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robinmacharg @tomlongridge @fractalwrench