Add unhandled override support for unhandled errors #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
5454-unhandled-override-2
branch
4 times, most recently
from
2d4c98e
to
32c221f
Compare
kstenerud
force-pushed
the
5454-unhandled-override-2
branch
from
32c221f
to
680effc
Compare
|
I'm a little concerned about the effect that adding so many new E2E scenarios will have on the run time. I think there's a 1 hour time limit which exceeding will result in a failure. Is it important to check the unhandled -> handled override for so many different types of crashes? |
|
Hmm I suppose since the same path is taken by all unhandled exceptions, we'd only really need it in one place. |
kstenerud
force-pushed
the
5454-unhandled-override-2
branch
2 times, most recently
from
e6bc161
to
1b4da42
Compare
nickdowell
reviewed
Dec 4, 2020
nickdowell
reviewed
Dec 4, 2020
kstenerud
force-pushed
the
5454-unhandled-override-2
branch
from
1b4da42
to
922a46d
Compare
nickdowell
approved these changes
Dec 4, 2020
kattrali
suggested changes
Dec 4, 2020
kstenerud
force-pushed
the
5454-unhandled-override-2
branch
from
922a46d
to
2f7c1a3
Compare
kattrali
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
With the last override PR, we now support overriding the
unhandledstatus of handled exceptions (allowing the user to mark handled errors as "unhanded". This PR adds functionality to mark "unhandled" errors as "handled", setting the same "unhandledOverridden" field whenever this happens.Design
See ROAD-732
Changeset
BugsnagEvent now detects whether an error has changed from unhandled to handled or vice versa, and sets
unhandledOverriddento mark when it happens, adjustinghandledCountandunhandledCountto compensate.unhandledOverriddenonly gets encoded to JSON when it's true.Testing
Added "override" versions of the unhandled exception tests which change
unhandledto false in a crash callback function.