Skip to content

Commit

Permalink
Merge pull request #151 from bugsnag/5963-strong-name-assemblies
Browse files Browse the repository at this point in the history
[PLAT-5963] strong name sign assemblies
  • Loading branch information
yousif-bugsnag committed Jan 10, 2022
2 parents ac47c53 + a96f621 commit 8a8bf41
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 0 deletions.
Binary file added Bugsnag.snk
Binary file not shown.
2 changes: 2 additions & 0 deletions Directory.build.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<Project>
<PropertyGroup>
<OutputPath>$(BaseOutputPath)</OutputPath>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)Bugsnag.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>
</PropertyGroup>
</Project>
8 changes: 8 additions & 0 deletions UPGRADING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
Upgrading
=========

## 2.x to 3.x

If you are targeting .NET Framework, v3.0.0 contains binary breaking changes due to the introduction of strong name signing. You will need to re-compile your application against the new version. If you are referencing a library that also references Bugsnag you may also need to add a binding redirect or enable automatic binding redirection in your project file:

```
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
```

## 1.x to 2.x

*Our .NET notifier has gone through some major improvements, and there are some changes you'll need to make to get onto the new version.*
Expand Down
1 change: 1 addition & 0 deletions src/Bugsnag.AspNet.Core/Bugsnag.AspNet.Core.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<Title>Bugsnag .NET ASP.NET Core Notifier</Title>
<Description>The Bugsnag Notifier for ASP.NET Core gives you instant notification of exceptions thrown from your ASP.NET Core applications. Any uncaught exceptions will trigger a notification to be sent to your Bugsnag project.</Description>
<TargetFrameworks>netstandard1.3;netstandard2.0</TargetFrameworks>
<SignAssembly>false</SignAssembly>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\Bugsnag\Bugsnag.csproj" />
Expand Down
3 changes: 3 additions & 0 deletions src/Directory.build.props
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<Project>

<Import Project="..\Directory.Build.props"/>

<PropertyGroup>
<Authors>snmaynard kattrali martin308</Authors>
<Version></Version>
Expand Down
5 changes: 5 additions & 0 deletions tests/Directory.build.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<Project>
<PropertyGroup>
<SignAssembly>false</SignAssembly>
</PropertyGroup>
</Project>

0 comments on commit 8a8bf41

Please sign in to comment.