-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #127 from bugsnag/next
Release v2.2.1
- Loading branch information
Showing
28 changed files
with
314 additions
and
333 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,84 +1,15 @@ | ||
| ## Goal | ||
|
|
||
| <!-- What is the intent of this change? | ||
| e.g. "When initializing the Bugsnag client, it is currently difficult to (...) | ||
| this change simplifies the process by (...)" | ||
| "Improves the performance of data filtering" | ||
| "Adds additional test coverage to multi-threaded use of Configuration | ||
| objects" | ||
| --> | ||
|
|
||
| <!-- For new features, include design documentation: | ||
| <!-- Why is this change necessary? --> | ||
|
|
||
| ## Design | ||
|
|
||
| Why was this approach to the goal used? | ||
| --> | ||
| <!-- Why was this approach used? --> | ||
|
|
||
| ## Changeset | ||
|
|
||
| <!-- What structures or properties or functions were: | ||
| ### Added | ||
| ### Removed | ||
| ### Changed | ||
| --> | ||
| <!-- What changed? --> | ||
|
|
||
| ## Tests | ||
|
|
||
| <!-- How was this change tested? What manual and automated tests were | ||
| run/added? --> | ||
|
|
||
| ## Discussion | ||
|
|
||
| ### Alternative Approaches | ||
|
|
||
| <!-- What other approaches were considered or discussed? --> | ||
|
|
||
| ### Outstanding Questions | ||
|
|
||
| <!-- Are there any parts of the design or the implementation which seem | ||
| less than ideal and that could require additional discussion? | ||
| List here: --> | ||
|
|
||
| ### Linked issues | ||
|
|
||
| <!-- | ||
| Fixes # | ||
| Related to # | ||
| --> | ||
|
|
||
| ## Review | ||
|
|
||
| <!-- When submitting for review, consider the points for self-review and the | ||
| criteria which will be used for secondary review --> | ||
|
|
||
| For the submitter, initial self-review: | ||
|
|
||
| - [ ] Commented on code changes inline explain the reasoning behind the approach | ||
| - [ ] Reviewed the test cases added for completeness and possible points for discussion | ||
| - [ ] A changelog entry was added for the goal of this pull request | ||
| - [ ] Check the scope of the changeset - is everything in the diff required for the pull request? | ||
| - This pull request is ready for: | ||
| - [ ] Initial review of the intended approach, not yet feature complete | ||
| - [ ] Structural review of the classes, functions, and properties modified | ||
| - [ ] Final review | ||
|
|
||
| For the pull request reviewer(s), this changeset has been reviewed for: | ||
|
|
||
| - [ ] Consistency across platforms for structures or concepts added or modified | ||
| - [ ] Consistency between the changeset and the goal stated above | ||
| - [ ] Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added? | ||
| - [ ] Usage friction - is the proposed change in usage cumbersome or complicated? | ||
| - [ ] Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc? | ||
| - [ ] Concurrency concerns - if components are accessed asynchronously, what issues will arise | ||
| - [ ] Thoroughness of added tests and any missing edge cases | ||
| - [ ] Idiomatic use of the language | ||
| <!-- How was it tested? --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| <package id="Bugsnag" version="2.0.2" targetFramework="net35" /> | ||
| <package id="Bugsnag.AspNet" version="2.0.2" targetFramework="net35" /> | ||
| <package id="Bugsnag.ConfigurationSection" version="2.0.2" targetFramework="net35" /> | ||
| <package id="Bugsnag" version="2.2.0" targetFramework="net35" /> | ||
| <package id="Bugsnag.AspNet" version="2.2.0" targetFramework="net35" /> | ||
| <package id="Bugsnag.ConfigurationSection" version="2.2.0" targetFramework="net35" /> | ||
| </packages> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,55 @@ | ||
| using System; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.AspNetCore.Mvc; | ||
| using Bugsnag; | ||
|
|
||
| namespace aspnetcore11_mvc.Controllers | ||
| { | ||
| public class HomeController : Controller | ||
| public class HomeController : Controller | ||
| { | ||
| private readonly IClient _client; | ||
| private Dictionary<string, string> _messageLookup = new Dictionary<string, string>() | ||
| { | ||
| private readonly IClient _client; | ||
|
|
||
| public HomeController(IClient client) | ||
| { | ||
| _client = client; | ||
| } | ||
|
|
||
| public IActionResult Index() | ||
| { | ||
| return View(); | ||
| } | ||
|
|
||
| public IActionResult About() | ||
| { | ||
| _client.Breadcrumbs.Leave("Here comes the exception..."); | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
| public IActionResult Contact() | ||
| { | ||
| ViewData["Message"] = "Your contact page."; | ||
|
|
||
| return View(); | ||
| } | ||
|
|
||
| public IActionResult Error() | ||
| { | ||
| return View(); | ||
| } | ||
| { | ||
| "Contact", "Contact page" | ||
| } | ||
| }; | ||
|
|
||
| public HomeController(IClient client) | ||
| { | ||
| _client = client; | ||
|
|
||
| } | ||
|
|
||
| public IActionResult Index() | ||
| { | ||
| return View(); | ||
| } | ||
|
|
||
| public IActionResult About() | ||
| { | ||
| _client.Breadcrumbs.Leave("Here comes the exception..."); | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
| public IActionResult Contact() | ||
| { | ||
| try | ||
| { | ||
| ViewData["Message"] = _messageLookup["Cotnact"]; | ||
| } | ||
| catch (Exception e) | ||
| { | ||
| _client.Notify(e); | ||
| ViewData["Message"] = "Your contact page."; | ||
| } | ||
|
|
||
| return View(); | ||
| } | ||
|
|
||
| public IActionResult Error() | ||
| { | ||
| return View(); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.