Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InProject namespaces detection #102

Merged
merged 3 commits into from May 29, 2018
Merged

Fix InProject namespaces detection #102

merged 3 commits into from May 29, 2018

Conversation

jviolas
Copy link
Contributor

@jviolas jviolas commented May 29, 2018

Goal

Fix the "in project" namespace detection for stack trace lines. (issue #100)

Changeset

Changed

Just change the way StackTraceLine.InProject property is updated and break out of the loop on ProjectNamespaces as soon as the line is detected as in project.

Tests

I've done some manual test by sending exception to my bugsnag project

Linked issues

Fixes #100

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@jviolas jviolas changed the title Fix InProject detection Fix InProject namespaces detection May 29, 2018
@martin308
Copy link
Contributor

@jviolas thanks for the contribution, good catch! I'll add some tests around this behaviour and then it looks good to go

Copy link
Contributor

@martin308 martin308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again @jviolas 🎉

@martin308 martin308 merged commit d34cad2 into bugsnag:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants