Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved http exception handling #103

Merged
merged 3 commits into from May 30, 2018

Conversation

martin308
Copy link
Contributor

@martin308 martin308 commented May 30, 2018

Goal

While looking for memory leaks in response to #99 I noticed that in the event that there is an exception while sending a report we continue trying to send the report when we should just stop trying to send the report as we will just get further exceptions if we continue the process. I also noticed that under high load the notify endpoint closes keep alive connections pretty aggressively which results in reports falling to send so I have disabled keep alive on the platforms where we can.

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

You don't need explicit readonly backing fields anymore
If we get an exception sending the request then we shouldn't call the read callback as there is nothing to read
The notify endpoint does not seem keep alive friendly right now
@martin308 martin308 requested a review from a team May 30, 2018 18:31
@martin308 martin308 merged commit 980b36b into master May 30, 2018
@martin308 martin308 deleted the martin308/improved-http-exception-handling branch May 30, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants