Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle any exceptions raised when reading files for code segments #123

Merged
merged 5 commits into from
May 7, 2020
Merged

Handle any exceptions raised when reading files for code segments #123

merged 5 commits into from
May 7, 2020

Conversation

twometresteve
Copy link
Contributor

Goal

Prevent a crash when reading code segments from a file fails.

Tests

Manually tested locally by forcing an exception and inspecting the stack traces displatyed in the dashboard.

tomlongridge
tomlongridge approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@tomlongridge tomlongridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small consistency nit and needs a changelog entry, but LGTM otherwise.

src/Bugsnag/Polyfills.cs Outdated Show resolved Hide resolved
@twometresteve @tomlongridge
Qualify uses of System.Exception
3c1d713 
Co-authored-by: Tom Longridge <tom@bugsnag.com>
@twometresteve twometresteve changed the title Guard file readlines Handle any exceptions raised when reading files for code segments May 7, 2020
@twometresteve twometresteve merged commit ed5e67a into next May 7, 2020
@twometresteve twometresteve deleted the guard-file-readlines branch May 7, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twometresteve @tomlongridge @bugsnagbot