Fix crash when stackframe method is null #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,14 +78,17 @@ public static class InternalMiddleware | |||
| { | |||
| foreach (var stackTraceLine in exception.StackTrace) | |||
| { | |||
| foreach (var @namespace in report.Configuration.ProjectNamespaces) | |||
| if (!Polyfills.String.IsNullOrWhiteSpace(stackTraceLine.MethodName)) | |||
There was a problem hiding this comment.
I think it would be worth adding another unit test case to cover the null case, given that we have a unit test framework in place for the class.
yousif-bugsnag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes a crash in the notifier when a Stackframe reports a
nullmethod.Design
It's possible that
StackFrame.GetMethod()may returnnullin some circumstances, so we should guard against this in our codeChangeset
Added null checks wherever code accesses
StackTraceLine.MethodnameTesting
Tested manually by manipulating stacktraces in the debugger to cause a crash.