[PLAT-7415] - Ensure breadcrumbs are returned in the correct order #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 2.2.3-alpha
Release v2.2.3-alpha.1
Release 2.2.3 alpha with fixed github API token
…hen MaximumBreadcrumbs is exceeded
gareththackeray
approved these changes
Nov 29, 2021
twometresteve
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Breadcrumbs added after
MaximumBreadcrumbsis reached were being added from the start of the breadcrumb array, causing breadcrumbs to be added/returned in the wrong order.Also fixes
IndexOutOfRangeExceptionandOverflowExceptionerrors whenMaximumBreadcrumbsis set to a value < 1.Design
The previous implementation was a bit over complicated. It has now been simplified, using a LinkedList instead of an Array and checking the config value before adding breadcrumbs.
Testing
Manually verified that breadcrumbs are returned in the correct order after MaximumBreadcrumbs is exceeded. Updated automated test to cover this scenario (the issue was being masked previously as the test was adding exactly double the
MaximumBreadcrumbsvalue)