Ensure RemoveProjectRoots works for assemblies that are run on a OS that differs from their build OS. #154
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gareth Thackeray <gareth.thackeray@smartbear.com>
Release 3.0.0
yousif-bugsnag
requested changes
Feb 17, 2022
There was a problem hiding this comment.
Hi @sgtfrankieboy, thanks for the PR!
I think this needs a bit of tweaking for the case of Unix-style paths that already contain a trailing slash, e.g. /app/, as I think currently the prefix for these would end up as /app/\.
It looks like the new test scenarios are still checking Windows-style paths which is why this isn't being picked up.
yousif-bugsnag
added
the
awaiting feedback
|
Oh that was a pretty big brainfart on my part. Fixed the code and tests. |
xljones
added
backlog
yousif-bugsnag
previously approved these changes
Feb 28, 2022
yousif-bugsnag
approved these changes
Feb 28, 2022
|
Thanks for the contribution @sgtfrankieboy! |
|
This has now been released in v3.0.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes #152.
Design
This design ensures that the ProjectRoots provided still get the seperatorChar appended to the end of the path no matter if its a Windows or Unix-based path.
Changeset
The RemoveProjectRoots method now checks if a ProjectRoot provided is a Unix-based path or Windows and acts accordingly.
Testing
I added in two tests for testing Unix-based paths to the MiddlewareTests file.