Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if event context is null before assigning #89

Merged
merged 4 commits into from
Apr 10, 2018
Merged

check if event context is null before assigning #89

merged 4 commits into from
Apr 10, 2018

Conversation

tremlab
Copy link
Contributor

@tremlab tremlab commented Apr 7, 2018

No description provided.

tremlab and others added 4 commits April 6, 2018 17:46
@tremlab
check if event context is null before assigning
1bf7f7a
@martin308
Fix tests
00af602 
Add a context to the report so that the existing test cases pass
@martin308
Add new test cases
eebf4c4 
Cover the new cases where an existing context may have been set
@martin308
Update changelog
12fb2d6
martin308
martin308 approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@martin308 martin308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tremlab, looks good!

@martin308 martin308 merged commit 06b9ab0 into bugsnag:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin308 martin308 martin308 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tremlab @martin308