Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve metadata filtering #90

Merged
merged 6 commits into from
Apr 27, 2018
Merged

Improve metadata filtering #90

merged 6 commits into from
Apr 27, 2018

Conversation

martin308
Copy link
Contributor

@martin308 martin308 commented Apr 19, 2018 •
edited
Loading

  • Applies the metadata filtering to all of the required sections of the payload. Previously we were missing both request and user
  • Refactor how filtering is applied
  • Apply the metadata filtering to the sessions payload as well

@martin308 martin308 requested a review from a team April 19, 2018 00:32
fractalwrench
fractalwrench reviewed Apr 19, 2018
View reviewed changes
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. This PR would be a good candidate for a mazerunner scenario (if that's already setup on .NET)

@martin308
Add tests for Get & AddToPayload
08c4327
@martin308
Remove old metadata filtering
5fbbe32 
This will be replaced in the next few commits with a new approach
@martin308
Add IFilterable interface
bd5eef9 
Use this interface to mark sections of the payload that should have filtering applied to them
@martin308
Apply filtering as part of serialization
7a33308 
Use the new IFilterable interface to apply the provided key filtering during serialization
@martin308
Apply filtering to sessions payload
53af96d 
This previously did not have any filtering applied to it. It sends some of the same information that the error payload does though and should have the same filtering applied
@martin308
Update changelog
4120571
@martin308 martin308 force-pushed the martin308/metadata-filtering branch from 4e591fe to 4120571 Compare April 27, 2018 17:55
@martin308 martin308 merged commit 607b70f into master Apr 27, 2018
@martin308 martin308 deleted the martin308/metadata-filtering branch April 27, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalwrench fractalwrench fractalwrench left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martin308 @fractalwrench