Improve request context setting #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was raised by @tremlab, the context from the request is not available due it being set after the middleware has already been run. This fixes this issue by moving the setting of the context out of the middleware and moving it to being set when the request is updated in the event object
fractalwrench
previously approved these changes
Apr 20, 2018
Add this method back and add a comment around it not being used and liable to be removed in the next major version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was raised by @tremlab, the context from the request is not available in the middleware due it being set after the middleware has already been run. This fixes this issue by moving the setting of the context out of the middleware and moving it to being set when the request is updated in the event object.