Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support errors.Unwrap and errors.Is #194

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Support errors.Unwrap and errors.Is #194

merged 3 commits into from
Oct 12, 2022

Conversation

jaycetde
Copy link
Contributor

@jaycetde jaycetde commented Oct 6, 2022

Goal

Resolves #193

  • Add an Unwrap method to support errors.Unwrap(err) and errors.Is(err, SomeErr)

Design

Changeset

Testing

@johnkiely1
Copy link
Member

Thanks for this, we will review as soon as priorities allow.

kattrali
kattrali approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kattrali kattrali merged commit 9c08c2b into bugsnag:master Oct 12, 2022
@luke-belton luke-belton mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali kattrali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support unwrapping error
3 participants
@jaycetde @johnkiely1 @kattrali