Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support app.type in error events #51

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Support app.type in error events #51

merged 1 commit into from
Jul 3, 2017

Conversation

jaschaephraim
Copy link
Contributor

No description provided.

@montanaflynn
Copy link

Paging Dr. @gkze, can we get a merge?

@gkze
Copy link

gkze commented Jun 30, 2017

What is the use case for this? That is not part of our default schema. You can send this as custom metadata and create a custom filter on it.

@jaschaephraim
Copy link
Contributor Author

I believe it is part of the event schema: https://docs.bugsnag.com/api/error-reporting/ . This allows sorting under the App Types tab in Timeline.

@montanaflynn
Copy link

The use case is to get our app types to show up in bugsnag so we can filter by them:

screen shot 2017-06-30 at 11 11 35 am

It appears to be included in the default schema listed here: https://docs.bugsnag.com/api/error-reporting/#library-configuration

        // Information about the app that crashed.
        // These fields are optional but highly recommended
        "app": {
          // The version number of the application which generated the error.
          // If appVersion is set and an error is resolved in the dashboard
          // the error will not unresolve until a crash is seen in a newer
          // version of the app.
          // (optional, default none, filtered)
          "version": "1.1.3",

          // The release stage that this error occurred in, for example
          // "development", "staging" or "production".
          // (optional, default "production", filtered)
          "releaseStage": "production",

          // A specialized type of the application, such as the worker queue or web
          // framework used, like "rails", "mailman", or "celery"
          "type": "rails"
        },

@kattrali
Copy link
Contributor

kattrali commented Jul 3, 2017

Thanks for the contribution, @jaschaephraim. Looks good. It seems app type was overlooked when setting up the configuration for the library. I'm drafting a change to the docs and then will release this. 👍

@kattrali
Copy link
Contributor

kattrali commented Jul 3, 2017

@kattrali kattrali merged commit 5f933ea into bugsnag:master Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants