Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Revel release v0.18.0 #63

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Support Revel release v0.18.0 #63

merged 2 commits into from
Dec 6, 2017

Conversation

EightB1ts
Copy link
Contributor

Hello,

Revel introduced breaking changes with v0.18.0 - Changelog.

http.Request is no longer contained in revel.Request revel.Request remains functionally the same but you cannot extract the http.Request from it. You can get the http.Request from revel.Controller.Request.In.GetRaw().(*http.Request)

@kattrali
Copy link
Contributor

kattrali commented Dec 4, 2017

Thanks for the patch, @EightB1ts. This is a tricky one since we hope to maintain compatibility where possible for folks using Revel <0.18 and go get. Do you know if Revel exposes the version number in some way offhand?

Implements basic semantic versioning (Major/Minor changes) along with support for v0.18.0.
@EightB1ts
Copy link
Contributor Author

Sorry for the delay @kattrali - I've added the ability to do basic versioning to hopefully maintain compatibility. I've had the chance to test v0.17.0 and it seems to be working. Thanks!

@kattrali
Copy link
Contributor

kattrali commented Dec 5, 2017

Wow! This is amazing, @EightB1ts.

@EightB1ts
Copy link
Contributor Author

@kattrali Thanks! Hopefully I can get done with my revel app soon so I can begin integrating bugsnag! :)

@kattrali kattrali merged commit c94efc7 into bugsnag:master Dec 6, 2017
kattrali added a commit that referenced this pull request Dec 6, 2017
@kattrali
Copy link
Contributor

kattrali commented Dec 6, 2017

Thanks again, I'll make a new release shortly 🙌

@EightB1ts
Copy link
Contributor Author

Face Palm Line 47 should be removed
event.RawData = append(event.RawData, controller.Request)
I'm not sure how that managed to sneak itself back in there....I'm glad I double checked. Sorry about that!

@kattrali
Copy link
Contributor

kattrali commented Dec 6, 2017

Huh, I thought I did. Thanks for the comment, I'll patch it.

kattrali added a commit that referenced this pull request Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants