Add configurable connection and read timeouts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llehtinen
force-pushed
the
add_configurable_network_timeouts
branch
from
0336efe
to
7286c3e
Compare
|
Thanks, @llehtinen. This looks good. Merging after I add some documentation around the additional properties. |
kattrali
added a commit
that referenced
this pull request
Dec 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was toying with a Bugsnag logback appender which was calling client.notify inside the synchronized append method. Thread dump showed one thread stuck in
int status = conn.getResponseCode();inside HttpClient, and a few hundred threads waiting for it to release the lock it was holding.Apparently if not configured, the connect and read timeouts are infinite. I added 60s defaults and tried to make them configurable. Let me know what you think.