New major version of notifier #47

loopj · 2016-08-25T03:53:52Z

ChangeLog

Uses Jackson for streaming JSON serialization
Uses Gradle as the build system
Logs internally using org.slf4j.Logger
Severity is now an enum instead of a String
Request information is automatically collected in Servlet API apps
JVM runtime, O/S, and locale diagnostics are collected
The Client object has been renamed to Bugsnag
The Event object has been renamed to Report
Report object is now exposed for ease of attaching diagnostics to error reports
Targets Java 1.6
Callbacks now support Java 8 lambda syntax, eg:

bugsnag.addCallback((report) -> {
    report.setSeverity(Severity.ERROR);
});

Chaining support added to Report methods

bugsnag.addCallback((report) -> {
    report.setSeverity(Severity.ERROR).setUserId("123");
});

Can now add a Callback to Bugsnag.notify calls

bugsnag.notify(ex, (report) -> {
    report.addToTab("tab", "key", "value");
});

Can now change the API key on a per-report basis using Callbacks

bugsnag.notify(ex, (report) -> {
    report.setApiKey("123456");
});

Error report delivery is now fully swappable via the Delivery interface

// Low-level use
Delivery delivery = new AsyncHttpDelivery();
delivery.setEndpoint(...);
bugsnag.setDelivery(delivery);

// Use synchronous delivery instead
Delivery delivery = new SyncHttpDelivery();
bugsnag.setDelivery(delivery);

// Shortcuts
bugsnag.setEndpoint(...);
bugsnag.setProxy(...);
bugsnag.setTimeout(...);

kattrali · 2016-08-25T15:11:34Z

1 commit

+1,739 −1,808 changed lines

… challenge accepted.

kattrali · 2016-09-05T10:27:59Z

FYI a couple of *.class files were checked in

kattrali · 2016-09-05T10:28:41Z

And build files within examples/build

kattrali · 2016-09-05T10:31:01Z

src/main/java/com/bugsnag/Client.java

-    }
+        // Don't notify if this error class should be ignored
+        if (config.shouldIgnoreClass(report.getExceptionName())) {
+            logger.debug("Error not reported to Bugsnag - exception class is in 'ignoreClasses'");


Probably should log the class name in this message, for clarity

loopj

Was this a style decision? Adding simple getter/setter functions increases the size of the jar, which admittedly is not a major concern, but not sure of the benefits.

duncanhewett · 2016-09-29T08:52:17Z

@loopj It was just a best practice/style decision, but I've reverted that commit.

duncanhewett · 2016-10-01T19:38:48Z

To get the build to work in all the JDKs I have:

Switched to Gradle 2.14 for JDK6 support
Removed the nebula.optional-base plugin and changed the servlet-api dependency to compileOnly which I think acheives the same effect
Changed the Travis build to use jdk_switcher to run different builds per JDK
Only build example apps on JDK8 (so they can use Lambda syntax)
Only run checkstyle on JDK8 (plugin doesn't support JDK6)
Use jackson-databind version 2.6.7 for JDK6 compability

loopj

Green tests 🎉

foygl · 2016-10-14T15:24:26Z

src/main/java/com/bugsnag/Report.java

+     * @return the exceptions that make up the error.
+     */
+    @Expose
+    public List<Exception> getExceptions() {


This either needs to be protected or Exception needs to be public.

Changed, I don't think it needs to be public.

foygl · 2016-10-14T15:24:42Z

src/main/java/com/bugsnag/Report.java

+    }
+
+    @Expose
+    public List<ThreadState> getThreads() {


This either needs to be protected or ThreadState needs to be public.

Changed, I don't think it needs to be public.

foygl · 2016-10-14T15:47:06Z

src/main/java/com/bugsnag/Report.java

+     * @param config    the configuration for the report.
+     * @param throwable the error to create the report for.
+     */
+    public Report(Configuration config, Throwable throwable) {


If the expectation is that this always get built from Bugsnag.buildReport we should remove the public here to make this package protected. This will enforce the API usage which will make it easier to maintain and refactor in the future.

Changed, I don't think it needs to be public.

foygl · 2016-10-24T14:21:22Z

src/main/java/com/bugsnag/Bugsnag.java

+     *                  {@link Severity#WARNING} or {@link Severity#INFO}
+     * @return true unless the error report was ignored
+     */
+    public boolean notify(Throwable throwable, Severity severity) {


Do we need a notify(Throwable, Severity, Callback) for completeness?

I think we should add this yeah

foygl · 2016-10-24T14:40:26Z

src/main/java/com/bugsnag/MetaData.java

-                JSONUtils.safePut(tab, entry.getKey(), entry.getValue());
-            }
-        } else {
-            addToTab("Custom Data", tabName, value);


Are we officially dropping support for adding data without specifying a tab?

I think so, it seems best to force choosing a tab name.

foygl · 2016-10-24T14:53:08Z

src/main/java/com/bugsnag/Bugsnag.java

+     * @param endpoint the endpoint to send reports to
+     * @see #setDelivery
+     */
+    public void setEndpoint(String endpoint) {


We now need to declare the protocol explicitly i.e. can't use localhost have to use http://localhost. We should document this in the migration instructions.

loopj · 2016-10-31T15:28:09Z

Omg

WIP new major version of notifier

4d0072d

loopj changed the title ~~[WIP] new major version of notifier~~ [WIP] New major version of notifier Aug 25, 2016

kattrali reviewed Sep 5, 2016
View reviewed changes

Duncan Hewett added 15 commits September 27, 2016 11:19

Remove examples build artefacts

fffcf5b

Address logging review comments

ba339af

Tidy up

c7233ca

Target JDK 1.6

e2821d3

Add Client tests

f3109cf

Ignore common IDE files

385c640

Rename Client to Bugsnag for clarity and to avoid namespace clashes

ca6cd12

Add Gradle Wrapper

197b104

Fix or supress compiler warnings

8df261d

Fix the simple example app

5ec205f

Fix servlet example

3816d47

Remove missing examples

ebfe4ff

Add getters and setters

aa1a27d

Document interfaces

ede763c

Auto format

84b38e1

loopj commented Sep 28, 2016

View reviewed changes

Revert "Add Getters and Setters"

d296781

Duncan Hewett added 4 commits September 29, 2016 12:39

Some more tests

61795c5

Fix checkstyle

0e99251

Fix checkstyle for tests

4e0583f

Try different travis builds for different JDKs

bf945ed

Duncan Hewett added 3 commits October 1, 2016 20:01

Clean for each JDK

06768c9

Checkstyle plugin not supported in JDK6, just run it for JDK8

5cdc7ba

Use Jackson version that supports JDK6

d39617b

loopj commented Oct 2, 2016

View reviewed changes

Duncan Hewett added 2 commits October 7, 2016 15:20

Add error handler to the servlet example

2740b78

Upgrade instructions

7da153e

foygl reviewed Oct 14, 2016

View reviewed changes

Duncan Hewett added 3 commits October 14, 2016 12:53

Don't send empty collections

f49715e

Tighten access to report constructor and methods

ffc992e

Add release process

3ace134

duncanhewett force-pushed the next branch from f34be89 to 3ace134 Compare October 17, 2016 02:25

Duncan Hewett and others added 4 commits October 16, 2016 19:26

Release from master

94089f5

Add defaults for properties

6cc70d6

Uppercase static LOGGER to meet Java naming conventions

60c9f29

Merge branch 'next' of github.com:bugsnag/bugsnag-java into next

e632dc9

foygl reviewed Oct 24, 2016

View reviewed changes

Duncan Hewett and others added 4 commits October 24, 2016 21:56

Add extra notify variant

4033ac7

Add setEndpoint to upgrading guide

8bc3cba

Checkstyle wars

8e3f456

Winning the checkstyle wars. Let's not be too restrictive...

d8be1a7

duncanhewett changed the title ~~[WIP] New major version of notifier~~ New major version of notifier Oct 31, 2016

duncanhewett merged commit f135429 into master Oct 31, 2016

duncanhewett deleted the next branch October 31, 2016 11:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New major version of notifier #47

New major version of notifier #47

loopj commented Aug 25, 2016 •

edited by duncanhewett

kattrali commented Aug 25, 2016

kattrali commented Sep 5, 2016

kattrali commented Sep 5, 2016

kattrali Sep 5, 2016

loopj left a comment

duncanhewett commented Sep 29, 2016

duncanhewett commented Oct 1, 2016 •

edited

loopj left a comment

foygl Oct 14, 2016

duncanhewett Oct 14, 2016

foygl Oct 14, 2016

duncanhewett Oct 14, 2016

foygl Oct 14, 2016 •

edited

duncanhewett Oct 14, 2016

foygl Oct 24, 2016

loopj Oct 24, 2016

duncanhewett Oct 25, 2016

foygl Oct 24, 2016

duncanhewett Oct 25, 2016

foygl Oct 24, 2016

loopj commented Oct 31, 2016

New major version of notifier #47

New major version of notifier #47

Conversation

loopj commented Aug 25, 2016 • edited by duncanhewett

ChangeLog

kattrali commented Aug 25, 2016

kattrali commented Sep 5, 2016

kattrali commented Sep 5, 2016

Choose a reason for hiding this comment

loopj left a comment

Choose a reason for hiding this comment

duncanhewett commented Sep 29, 2016

duncanhewett commented Oct 1, 2016 • edited

loopj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

foygl Oct 14, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loopj commented Oct 31, 2016

loopj commented Aug 25, 2016 •

edited by duncanhewett

duncanhewett commented Oct 1, 2016 •

edited

foygl Oct 14, 2016 •

edited