[PLAT-11664] Refactor navigation components #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browser bundle sizeNPM build
CDN build
Code coverageCoverage values did not change👌. Total:
Generated against 5161e2f on 18 March 2024 at 12:46:55 UTC |
Base automatically changed from
PLAT-11721/react-native-navigation-app-start-spans
to
integration/react-native-navigation
March 11, 2024 12:34
gingerbenw
force-pushed
the
integration/react-native-navigation
branch
from
a37556f
to
28ad5a9
Compare
gingerbenw
force-pushed
the
PLAT-11664/navigation-components
branch
from
26a393c
to
9a567f0
Compare
gingerbenw
force-pushed
the
PLAT-11664/navigation-components
branch
from
88b76a9
to
2f60963
Compare
gingerbenw
force-pushed
the
PLAT-11664/navigation-components
branch
from
fd0ac27
to
c028a42
Compare
|
|
||
| And the trace "Bugsnag-Span-Sampling" header equals "1:3" | ||
|
|
||
| And a span named "[AppStart/ReactNativeInit]" contains the attributes: |
There was a problem hiding this comment.
what's the reason for removing the app start test?
There was a problem hiding this comment.
ahh, I was just going to separate it out into a different scenario, but it appears I've missed the 'adding it back in' part
There was a problem hiding this comment.
I've now updated the feature to run the app start span scenario
yousif-bugsnag
approved these changes
Mar 18, 2024
gingerbenw
merged commit bb27f00
into
integration/react-native-navigation
38 checks passed
gingerbenw
added a commit
that referenced
this pull request
Mar 18, 2024
* Refactor navigation component to ensure spans are ended with the appropriate time and condition
gingerbenw
added a commit
that referenced
this pull request
Mar 19, 2024
* [PLAT-11664] Refactor navigation components to ensure spans are ended with the appropriate time and condition (#418) Add support for react-native-navigation library
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Ensure the
CompleteNavigationinteracts with navigation spans as intendedChangeset
complete-navigation.tsxto use a functional componentCompleteNavigationcomponentTesting
Updated end to end tests to implement
CompleteNavigationcomponent in all use cases