[PLAT-11855] Forward navigation refs #431
Merged
+61
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gation-performance Update package name and use default export to match the convention used in the error notifier
…performance Update package name and use default export to match the convention used in the error notifier
gingerbenw
force-pushed
the
PLAT-11855/navigation-container-ref
branch
from
464ab9c
to
6a1fba4
Compare
Browser bundle sizeNPM build
CDN build
Code coverageCoverage values did not change👌. Total:
Generated against 03c29f4 on 27 March 2024 at 11:49:29 UTC |
yousif-bugsnag
approved these changes
Mar 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix an issue where refs are not forwarded to the NavigationContainer
Changeset
Update createNavigationContainer to pass refs to the returned component and update types to ensure compatibility
Testing
Added unit test to ensure ref is passed correctly and navigation can occur