Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to notify_release_stages for env var default #142

Closed
wants to merge 1 commit into from
Closed

Update to notify_release_stages for env var default #142

wants to merge 1 commit into from

Conversation

fire015
Copy link

@fire015 fire015 commented Jul 15, 2016

Convert env var BUGSNAG_NOTIFY_RELEASE_STAGES to an array and allow comma separation as you can't set an array in an env file.

Convert env var BUGSNAG_NOTIFY_RELEASE_STAGES to an array and allow comma separation.
@GrahamCampbell
Copy link
Contributor

Thanks. Could we get it more concise though? Surely this would do the same:

explode(',', env('BUGSNAG_NOTIFY_RELEASE_STAGES', '')) ?: null,

@GrahamCampbell
Copy link
Contributor

Ping @kattrali.

@fire015
Copy link
Author

fire015 commented Jul 18, 2016

No that won't evaluate to null - https://3v4l.org/VoHsO

@GrahamCampbell
Copy link
Contributor

We should probably use the same exploding method we use for no in the proxy settings.

@GrahamCampbell
Copy link
Contributor

Thanks, for the PR. I'll take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants