Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the handle method #242

Merged
merged 3 commits into from
Jul 26, 2017
Merged

Use the handle method #242

merged 3 commits into from
Jul 26, 2017

Conversation

strebl
Copy link
Contributor

@strebl strebl commented Jul 25, 2017

Because of the PR laravel/framework#20024, the fire method isn't supported anymore and therefore it doesn't work with the upcoming 5.5 release.

fire has been replaced by handle since laravel/framework@970836c (version 5.0.30).
Because of that, this PR is compatible down to version 5.0.30.

I'm not sure if I should do something in the composer.json, maybe @GrahamCampbell can help me here 馃檪

@GrahamCampbell
Copy link
Contributor

GrahamCampbell commented Jul 25, 2017

Yes, please update the composer.json to '^5.0.30' instead of ^5.0. :)

@strebl
Copy link
Contributor Author

strebl commented Jul 25, 2017

Thanks @GrahamCampbell!

I updated the composer.json.

@kattrali
Copy link
Contributor

Can we have both methods to keep it compatible with ^5.0?

@strebl
Copy link
Contributor Author

strebl commented Jul 26, 2017

It's your decision in the end, but I think because 5.0.30 is part of the 5.0 release and 5.0 isn't actively supported anymore, the change is totally fine.

But i'll update the PR if you want the compatibility. 馃憤

@kattrali
Copy link
Contributor

@strebl Thanks! I think being compatible would be best. Nobody should need to upgrade Laravel just to update Bugsnag unless its something major.

@GrahamCampbell
Copy link
Contributor

I think being compatible would be best.

I agree. We just need to add a fire method that just goes and calls the handle method. :)

@strebl
Copy link
Contributor Author

strebl commented Jul 26, 2017

Thanks for your feedback!

I updated my PR with your suggestions.

Anything else I should change?

@GrahamCampbell
Copy link
Contributor

馃憤

@kattrali kattrali merged commit 4fe3cbe into bugsnag:master Jul 26, 2017
@kattrali
Copy link
Contributor

Thanks, @strebl! 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants