-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the handle method #242
Conversation
Yes, please update the composer.json to '^5.0.30' instead of |
Thanks @GrahamCampbell! I updated the composer.json. |
Can we have both methods to keep it compatible with ^5.0? |
It's your decision in the end, but I think because 5.0.30 is part of the 5.0 release and 5.0 isn't actively supported anymore, the change is totally fine. But i'll update the PR if you want the compatibility. 馃憤 |
@strebl Thanks! I think being compatible would be best. Nobody should need to upgrade Laravel just to update Bugsnag unless its something major. |
I agree. We just need to add a fire method that just goes and calls the handle method. :) |
Thanks for your feedback! I updated my PR with your suggestions. Anything else I should change? |
馃憤 |
Thanks, @strebl! 馃帀 |
Because of the PR laravel/framework#20024, the
fire
method isn't supported anymore and therefore it doesn't work with the upcoming 5.5 release.fire
has been replaced byhandle
since laravel/framework@970836c (version5.0.30
).Because of that, this PR is compatible down to version
5.0.30
.I'm not sure if I should do something in the composer.json, maybe @GrahamCampbell can help me here 馃檪