Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logger notify level to Laravel configuration #265

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Add logger notify level to Laravel configuration #265

merged 2 commits into from
Dec 14, 2017

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Nov 15, 2017 •
edited

Adds an additional configuration option - logger_notify_level to laravel configuration to interface with the bugsnag-psr-logger change. Maps to BUGSNAG_LOGGER_LEVEL automatically.

kattrali
kattrali approved these changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The only case which remains unhandled is when LOGGER_LEVEL is set to an invalid value, which should be discovered and thrown within BugsnagLogger.php.

@Cawllec Cawllec merged commit ceb2487 into master Dec 14, 2017
@GrahamCampbell GrahamCampbell deleted the cawllec/log-level-config branch February 11, 2018 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali kattrali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cawllec @kattrali