Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Laravel runtime version reporting #352

Merged
merged 5 commits into from Jun 14, 2019

Conversation

tomlongridge
Copy link
Contributor

@tomlongridge tomlongridge commented May 22, 2019

Uses new hook in Configuration to append the Laravel/Lumen application version to device data to
make it reportable.

Goal

Augments reporting with the version of Laravel or Lumen in use when an event occurred in case of issues in a specific version of the framework.

Design

Added data to device.runtimeVersions.laravel and .lumen as per other notifiers.

Changeset

Added

  • BugsnagServiceProvider.addRuntimeVersion - new function that determines the version and key name to use

Changed

  • BugsnagServiceProvider.register - appends the runtime version information to the device data through the Bugsnag client

Tests

  • No unit tests present for this level of testing - checked the data was present after running the example laravel and lumin projects (requires the feature branch of bugsnag-php)

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@tomlongridge tomlongridge force-pushed the tom/php-runtime-versions branch 2 times, most recently from b0feaf2 to 5aed502 Compare May 29, 2019 12:37
@tomlongridge tomlongridge marked this pull request as ready for review May 29, 2019 12:38
Uses new hook in Configuration class of bugsnag-php 3.17.0 to append the Laravel/Lumen application version
to device data to make it reportable.

Also fixed Mazerunner tests by updating composer.json and removing lock from repo
@tomlongridge tomlongridge changed the base branch from master to next May 30, 2019 09:24
Copy link

@mikeewhite mikeewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomlongridge tomlongridge merged commit ee73359 into next Jun 14, 2019
@tomlongridge tomlongridge deleted the tom/php-runtime-versions branch June 14, 2019 14:46
@tomlongridge tomlongridge restored the tom/php-runtime-versions branch June 14, 2019 14:46
@tomlongridge tomlongridge deleted the tom/php-runtime-versions branch June 14, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants