Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tom/removed axios vulnerability in example #354

Merged
merged 2 commits into from Jun 14, 2019
Merged

Tom/removed axios vulnerability in example #354

merged 2 commits into from Jun 14, 2019

Conversation

tomlongridge
Copy link
Contributor

@tomlongridge tomlongridge commented May 30, 2019 •
edited

Goal

Bumped the Axios dependency in the Laravel 5.6 example project to remove warning.

@tomlongridge tomlongridge requested review from mikeewhite and removed request for mikeewhite May 30, 2019 09:20
@tomlongridge tomlongridge force-pushed the tom/removed-axiom-vulnerability-in-example branch from 82e0795 to decc114 Compare May 30, 2019 09:30
@tomlongridge tomlongridge changed the base branch from master to next May 30, 2019 09:31
@ankurk91
Copy link
Contributor

hey @tomlongridge
There is a typo in title, it should be axios
Current title may confuse users like me.

@tomlongridge tomlongridge changed the title Tom/removed axiom vulnerability in example Tom/removed axios vulnerability in example May 31, 2019
mikeewhite
mikeewhite approved these changes Jun 13, 2019
View reviewed changes
Copy link

@mikeewhite mikeewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomlongridge tomlongridge merged commit f22bd10 into next Jun 14, 2019
@tomlongridge tomlongridge deleted the tom/removed-axiom-vulnerability-in-example branch June 14, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeewhite mikeewhite mikeewhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomlongridge @ankurk91 @mikeewhite