-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new options for passing regexes to project root and strip path #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oot should be configured first when strip is given
…t stripPath then it should go after project configuration
Regex > Paths > Default Configure always project first to align with bugsnag-php which setup default strip path when setupProjectPath is invoked Remove dead short execution neither strip or project is given, as placing default configuration at the beginning made that extra predetermined configurations no more necessary "in my opinion" ;)
This has some really horrible code that's far too complicated for its own good, however all the tests pass so it should be easy enough to refactor
tomlongridge
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allow using the bugsnag-php options for setting the project root and strip path as regexes, rather than just strings
This adds two new options,
project_root_regex
andstrip_path_regex
, which can be used instead of the existingproject_root
andstrip_path
options to allow setting them as regexes, as introduced in bugsnag/bugsnag-php#514This is a continuation of #348
Changeset
Added
project_root
andstrip_path
options if they are also providedChanged
setProjectRoot
.These issues have been fixed in this branch
Tests
More unit tests have been added, building off of #395
Discussion
Alternative Approaches
Outstanding Questions
Linked issues
Related to bugsnag/bugsnag-php#514
Related to #348
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: