Default to empty when no key set #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah - I think that this will possibly require no changes on bugsnag-laravel and instead require a change to bugsnag-php here -> https://github.com/bugsnag/bugsnag-php/blob/master/src/Bugsnag/Client.php#L19 We could log instead of throwing there? |
|
Seems reasonable, glad to have another set of eyes. |
|
We'd also have to make a change to notify. We could probably add some tests to cover this in the php repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should not be required to provide a key in every environment if bugsnag is not being used there. This change sets a default 'empty' key, though I'd assume in addition we'd need to prevent triggering an upload. /cc @snmaynard
Fixes #65