New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a way to signify deploys #317
Conversation
This is a great idea! Very ergonomic for the framework libraries to use too. One concern though is that it probably shouldn’t be in the |
Maybe, but having a separate class here would mean a lot lot more code. The current class is called Client, not Notifier. |
Having this here also has the advantage that when people set the release stage in their bootstrapping process (such as in the boot method in a laravel service provider) all this stuff makes it into the deploy information. |
97ff0e3
to
2e1b649
Compare
That’s true. It makes sense to do this in a way that allows us to capture as many of the deployment fields as possible without additional overhead. Rolling with it. 🚄 |
:D |
Curios does this support svn repos which is protected with a username or a password? |
It specifically only supports github.com at the moment. |
We only use the repository url in order to link you to your code from app.bugsnag.com. You can still use the deployment API if you don't use GitHub, just that feature in the dashboard will be unavailable. All other features will still work just the same. |
Our ruby library has this available, and I think it would be really cool if the PHP one had it too.
It would be really nice to just be able to write
Bugsnag::deploy()
in Laravel, and that would notify Bugsnag of the deploy.