Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way to signify deploys #317

Merged
merged 1 commit into from Aug 4, 2016
Merged

Added a way to signify deploys #317

merged 1 commit into from Aug 4, 2016

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jul 25, 2016

Our ruby library has this available, and I think it would be really cool if the PHP one had it too.

It would be really nice to just be able to write Bugsnag::deploy() in Laravel, and that would notify Bugsnag of the deploy.

@kattrali
Copy link
Contributor

This is a great idea! Very ergonomic for the framework libraries to use too.

One concern though is that it probably shouldn’t be in the Client since we don’t want people arbitrarily or accidentally sending deploy notifications from applications. Maybe we could have a separate separate Deploy class which has a HttpClient. Then usage would be something like Bugsnag::Deploy::send(…)

@GrahamCampbell
Copy link
Contributor Author

Maybe, but having a separate class here would mean a lot lot more code. The current class is called Client, not Notifier.

@GrahamCampbell
Copy link
Contributor Author

Having this here also has the advantage that when people set the release stage in their bootstrapping process (such as in the boot method in a laravel service provider) all this stuff makes it into the deploy information.

@kattrali
Copy link
Contributor

kattrali commented Aug 4, 2016

That’s true. It makes sense to do this in a way that allows us to capture as many of the deployment fields as possible without additional overhead. Rolling with it. 🚄

@kattrali kattrali merged commit 0502904 into develop Aug 4, 2016
@kattrali kattrali deleted the deploys branch August 4, 2016 19:40
@GrahamCampbell
Copy link
Contributor Author

:D

@morloderex
Copy link

Curios does this support svn repos which is protected with a username or a password?

@GrahamCampbell
Copy link
Contributor Author

It specifically only supports github.com at the moment.

@GrahamCampbell
Copy link
Contributor Author

We only use the repository url in order to link you to your code from app.bugsnag.com. You can still use the deployment API if you don't use GitHub, just that feature in the dashboard will be unavailable. All other features will still work just the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants