Add ReturnTypeWillChange to Bugsnag\Breadcrumbs\Recorder
#630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This suppresses a deprecation in PHP 8.1 We may eventually need to avoid implementing Countable/Iterator in this class as it's not necessary and ReturnTypeWillChange may be removed at some point in the future. As that's _technically_ a BC break (though one that is unlikely to affect anyone) I've opted not to do that yet
kattrali
approved these changes
Sep 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This suppresses a deprecation in PHP 8.1 which causes CI to fail, added by the "add return type declarations for internal methods" RFC
We may eventually need to avoid implementing
Countable/Iteratorin this class as it's not necessary andReturnTypeWillChangemay be removed at some point in the future. As that's technically a BC break (though one that is unlikely to affect anyone as this class is unlikely to be used externally) I've opted not to do that yet