Fix error in ASGI middleware if the ASGI client
is None
#296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Our ASGI middleware assumes that the
client
in the ASGI scope cannot be None, but this isn't the case:This PR adds a guard to avoid an error if there is a
client
but it isNone
See #295
Testing
Added a unit test that runs an ASGI app with the
client
set toNone
. This fails in master but passes in this branchI also manually tested with Uvicorn on a unix socket (#295 (comment))