Apply params_filters
to URLs in request metadata
#318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
As part of our integration with web frameworks, we record the request URL in metadata. Some integrations only record the domain and path, but others also include the query string. However we weren't applying
params_filters
to the query string parameters and so could leak sensitive information if passed in the query stringThis PR applies
params_filters
to URLs in request metadata for the following integrations: