Allow setting the grouping hash when logging #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @0HyperCube, Thanks for the PR, we will review when priorities allow. |
imjoehaines
reviewed
Jul 5, 2023
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
imjoehaines
approved these changes
Jul 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allows changing the grouping hash when using the logger methods and the BugsnagHandler to send event, in order to close #253.
Changeset
An
extract_grouping_hashwas added to the logging handler to allow the grouping hash to be sent to theclient.notifyfunction.Testing
The
test_logging_grouping_hashensures that the specified hash value is sent.