Support the exceptiongroup PyPi package #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a backport of exception group functionality to Python 3.7+
This prevents different line numbers being reported by Python 3.7 vs newer versions It's maybe a little harder to read, but this is just a fixture file and shouldn't need to be updated often/at all
tomlongridge
approved these changes
Feb 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The exceptiongroup PyPi package is used by a number of projects to support Python 3.11's
ExceptionGroupon older Python versionsThis PR adds support for this package to bugsnag-python so that its back-ported
ExceptionGroupis treated identically to the built-inExceptionGroupThis is a tiny change to our library code, but the diff is big because of some finagling required to test it properly
Testing
The ExceptionGroup tests are now in their own file so that it can be run individually, though it's still part of the regular test suite
The test suite now also runs the above file with the
exceptiongrouppackage installed on all of its supported Python versions (3.7+)This gives us coverage of native exception groups on 3.11 and coverage of the
exceptiongrouppackage on 3.7+ with the exact same tests