Add exception notes as metadata #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
reviewed
Jul 4, 2023
gareththackeray
approved these changes
Jul 4, 2023
imjoehaines
reviewed
Jul 4, 2023
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
imjoehaines
reviewed
Jul 5, 2023
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
imjoehaines
reviewed
Jul 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Send new
__notes__field added in https://peps.python.org/pep-0678/Changeset
Add a notes tab if the exception has a
__notes__attribute.Testing
New
test_notestest added to ensure that the notes are added to the payload's metadata.