Accept PathLike as project root #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
reviewed
Jul 5, 2023
imjoehaines
force-pushed
the
string-project-path
branch
6 times, most recently
from
556eb80
to
4bbf5c9
Compare
On Python 3.5 we have to use PurePath, but can use PathLike on later versions
imjoehaines
force-pushed
the
string-project-path
branch
from
4bbf5c9
to
2470d1d
Compare
imjoehaines
approved these changes
Jul 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Currently if a PathLike object is passed in such as PurePath or Path from pathlib, the path will not be set and a warning is produced. The PathLike object should be converted to a string and accepted.
Changeset
Testing
Modification to
test_validate_project_rootto ensure that PathLike objects are accepted and converted to strings.