Ensure sessions are sent at exit #371
Merged
+80
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
approved these changes
Jan 29, 2024
|
|
||
| # deliver_sessions is _technically_ optional in that if you disable | ||
| # session tracking it will never be called | ||
| # this should be made mandatory in the next major release |
There was a problem hiding this comment.
Suggest raising a ticket for this, that we'll target against v5.x.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We use an
atexithook to deliver any outstanding sessions when the process exits, but this delivery happens asynchronously and therefore isn't guaranteed to finishThis PR adds an
optionsparameter todeliver_sessions(matchingdeliver) that allows forcing synchronous delivery and then uses this to send sessions synchronously at exit