This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
fix(iOS): Ensure reports on disk prior to app termination #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blocks are sync so the resolver should be called at the end
(Moved from notify()) This potentially allows the report to be delivered prior to termination, though not guaranteed.
15 tasks
fractalwrench
previously approved these changes
Nov 21, 2018
| RCT_EXPORT_METHOD(notify:(NSDictionary *)options) { | ||
| RCT_EXPORT_METHOD(notify:(NSDictionary *)options | ||
| resolve:(RCTPromiseResolveBlock)resolve | ||
| reject:(RCTPromiseRejectBlock)reject) { |
There was a problem hiding this comment.
We should update the declaration in the header file also
|
|
||
| @ReactMethod | ||
| public void notifyBlocking(ReadableMap payload, boolean blocking, com.facebook.react.bridge.Callback callback) { | ||
| public void notify(ReadableMap payload, com.facebook.react.bridge.Promise promise) { |
There was a problem hiding this comment.
We could get away without the fully qualified class name here - it was necessary previously to disambiguate between the two Callback classes
|
Both nice catches, thanks @fractalwrench ! |
Jekiwijaya
pushed a commit
to Jekiwijaya/bugsnag-react-native
that referenced
this pull request
Mar 11, 2019
## Goal Caches cocoapods on CI, which should reduce the amount of time required for jobs to run. This is recommended on the [Travis CI docs](https://docs.travis-ci.com/user/caching/#CocoaPods).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
(Extends #287)
Ensure report delivery while holding the native JS execution thread for as little time as possible in the case of non-fatal errors being reported. Updated the integration test to make the stack trace ridiculous.
Tests
Linked issues
Closes #287