This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
fix(ios): Ensure duplicate native reports are discarded #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using `[BugsnagReactNative start]`, its possible that fatal JS reports are sent despite the discard block if they fail to be filtered before they are sent. This change moves the block to be called the first time Bugsnag is started, in either layer.
kattrali
force-pushed
the
kattrali/fix-deliver-rctfatalexceptions
branch
from
40040d7
to
1093f8d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using
[BugsnagReactNative start], its possible that fatal JSreports are sent despite the discard block if they fail to be filtered
before they are sent. This change moves the block to be called the first
time Bugsnag is started, in either layer.
Tests