This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
fix: make JavaScriptException inherit from BugsnagException #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
alter-android-serialisation
branch
from
464479f
to
499e72a
Compare
fractalwrench
force-pushed
the
alter-android-serialisation
branch
from
499e72a
to
cfd358e
Compare
fractalwrench
force-pushed
the
alter-android-serialisation
branch
from
cfd358e
to
4f4b42c
Compare
bengourley
reviewed
Aug 15, 2019
| @@ -27,7 +29,7 @@ | |||
| private ReactContext reactContext; | |||
| private String libraryVersion; | |||
| private String bugsnagAndroidVersion; | |||
| static final Logger logger = Logger.getLogger("bugsnag-react-native"); | |||
| public static final Logger logger = Logger.getLogger("bugsnag-react-native"); | |||
There was a problem hiding this comment.
why is this change necessary?
There was a problem hiding this comment.
JavaScriptException needs to be in a different package to access package-private methods in BugsnagException, which meant it could no longer access this field.
bengourley
approved these changes
Aug 15, 2019
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
As part of bugsnag/bugsnag-android#553 the way exceptions are serialised in bugsnag-android was altered. This was to allow the exception name/message to be altered after a
BugsnagExceptionobject has been constructed.As part of this change, the exception serialisation was altered so that when building an error, all
Throwableobjects must be wrapped in aBugsnagExceptionif they are not already of that type. This meant thatJavaScriptException#toStream()was not invoked when serialising an error report, leading to the name being serialised ascom.bugsnag.JavaScriptException, rather than the name of the JS error.This changeset alters
JavaScriptExceptionto inheritBugsnagException, meaning that it is not wrapped in aBugsnagException, and that its customtoStreamimplementation will be invoked and the JS error serialised correctly.Tests
Tested manually in the example app and confirmed that
ReferenceErrorwas the error class and the correct stacktrace was collected.Additional unit test coverage has also been added in the Android PR.