Skip to content

Commit

Permalink
Merge branch 'next' into cawllec/sidekiq-3-handler
Browse files Browse the repository at this point in the history
  • Loading branch information
Cawllec committed May 14, 2018
2 parents e794cee + 6022a63 commit 6ba5dc1
Show file tree
Hide file tree
Showing 88 changed files with 680 additions and 1,392 deletions.
84 changes: 84 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
## Goal

<!-- What is the intent of this change?
e.g. "When initializing the Bugsnag client, it is currently difficult to (...)
this change simplifies the process by (...)"
"Improves the performance of data filtering"
"Adds additional test coverage to multi-threaded use of Configuration
objects"
-->

<!-- For new features, include design documentation:
## Design
Why was this approach to the goal used?
-->

## Changeset

<!-- What structures or properties or functions were:
### Added
### Removed
### Changed
-->

## Tests

<!-- How was this change tested? What manual and automated tests were
run/added? -->

## Discussion

### Alternative Approaches

<!-- What other approaches were considered or discussed? -->

### Outstanding Questions

<!-- Are there any parts of the design or the implementation which seem
less than ideal and that could require additional discussion?
List here: -->

### Linked issues

<!--
Fixes #
Related to #
-->

## Review

<!-- When submitting for review, consider the points for self-review and the
criteria which will be used for secondary review -->

For the submitter, initial self-review:

- [ ] Commented on code changes inline explain the reasoning behind the approach
- [ ] Reviewed the test cases added for completeness and possible points for discussion
- [ ] A changelog entry was added for the goal of this pull request
- [ ] Check the scope of the changeset - is everything in the diff required for the pull request?
- This pull request is ready for:
- [ ] Initial review of the intended approach, not yet feature complete
- [ ] Structural review of the classes, functions, and properties modified
- [ ] Final review

For the pull request reviewer(s), this changeset has been reviewed for:

- [ ] Consistency across platforms for structures or concepts added or modified
- [ ] Consistency between the changeset and the goal stated above
- [ ] Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
- [ ] Usage friction - is the proposed change in usage cumbersome or complicated?
- [ ] Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
- [ ] Concurrency concerns - if components are accessed asynchronously, what issues will arise
- [ ] Thoroughness of added tests and any missing edge cases
- [ ] Idiomatic use of the language
7 changes: 7 additions & 0 deletions example/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Bugsnag Example Apps

Examples of how to integrate Bugsnag into your applications can be found in this folder.

Examples for Que, Resque, and Sidekiq can be found in the `rails-51` folder, showing how to set these up in your Rails application.

For more information on setting up Bugsnag inside your Ruby application checkout our [Ruby integration guides](https://docs.bugsnag.com/platforms/ruby/).
7 changes: 0 additions & 7 deletions example/que/Gemfile

This file was deleted.

41 changes: 0 additions & 41 deletions example/que/Gemfile.lock

This file was deleted.

45 changes: 0 additions & 45 deletions example/que/README.md

This file was deleted.

37 changes: 0 additions & 37 deletions example/que/Rakefile

This file was deleted.

25 changes: 0 additions & 25 deletions example/que/app/jobs.rb

This file was deleted.

15 changes: 0 additions & 15 deletions example/que/app/migrations.rb

This file was deleted.

8 changes: 0 additions & 8 deletions example/que/app/model.rb

This file was deleted.

42 changes: 0 additions & 42 deletions example/rails-32/Gemfile

This file was deleted.

Loading

0 comments on commit 6ba5dc1

Please sign in to comment.