Breadcrumbs/Breadcrumb: Improve tests, convert to utc sooner

lib/bugsnag/breadcrumbs/breadcrumb.rb

@@ -9,7 +9,7 @@ class Breadcrumb
     # @return [Hash, nil] metadata hash containing strings, numbers, or booleans, or nil
     attr_accessor :meta_data
 
-    # @return [Symbol] set to `:auto` if the breadcrumb was automatically generated
+    # @return [Boolean] set to `true` if the breadcrumb was automatically generated
     attr_reader :auto
 
     # @return [Time] a Time object referring to breadcrumb creation time
@@ -36,7 +36,7 @@ def initialize(name, type, meta_data, auto)
       @auto = auto == :auto
 
       # Store it as a timestamp for now
-      @timestamp = Time.now
+      @timestamp = Time.now.utc
     end
 
     ##
@@ -69,7 +69,7 @@ def to_h
         :name => @name,
         :type => @type,
         :metaData => @meta_data,
-        :timestamp => @timestamp.utc.iso8601
+        :timestamp => @timestamp.iso8601
       }
     end
   end

spec/breadcrumbs/breadcrumb_spec.rb

@@ -53,7 +53,7 @@
     it "is stored as a timestamp" do
       breadcrumb = Bugsnag::Breadcrumbs::Breadcrumb.new(nil, nil, nil, nil)
 
-      expect(breadcrumb.timestamp).to be_within(0.5).of Time.now
+      expect(breadcrumb.timestamp).to be_within(0.5).of Time.now.utc
     end
   end
 
@@ -77,14 +77,17 @@
       breadcrumb = Bugsnag::Breadcrumbs::Breadcrumb.new("my message", "test type", {:a => 1, :b => 2}, :manual)
       output = breadcrumb.to_h
 
-      expect(output[:name]).to eq("my message")
-      expect(output[:type]).to eq("test type")
-      expect(output[:metaData]).to eq({ :a => 1, :b => 2})
-
       timestamp_regex = /^\d{4}\-\d{2}\-\d{2}T\d{2}:\d{2}:[\d\.]+Z$/
 
-      expect(output[:timestamp]).to be_a_kind_of(String)
-      expect(output[:timestamp]).to match(timestamp_regex)
+      expect(output).to match(
+        :name => "my message",
+        :type => "test type",
+        :metaData => {
+          :a => 1,
+          :b => 2
+        },
+        :timestamp => match(timestamp_regex)
+      )
     end
   end
 end