Added basic logger/log-device and tests #375
Conversation
Cawllec
added
needs discussion
lib/bugsnag/loggers/logger.rb
Outdated
| message = progname | ||
| end | ||
| if severity >= level | ||
| @log_device.write(message, progname, Bugsnag::Loggers::SEVERITIES[severity]) |
There was a problem hiding this comment.
Is it possible to define your own level? What happens if its over Logger::UNKNOWN?
lib/bugsnag/loggers/logger.rb
Outdated
| true | ||
| end | ||
|
|
||
| def reopen |
There was a problem hiding this comment.
What will this be used for?
There was a problem hiding this comment.
On the base class it's meant to close the connection to a file or IO object. While we're not hanging onto those objects I thought it'd be appropriate to cease logging in similar circumstances
lib/bugsnag/loggers/logger.rb
Outdated
| def initialize(level=Logger::INFO) | ||
| @open = true | ||
| @log_device = Bugsnag::Loggers::LogDevice.new | ||
| super @log_device, level |
There was a problem hiding this comment.
What is the benefit of having the device over nil here? The add() method could call Bugsnag.leave_breadcrumb directly.
There was a problem hiding this comment.
You're right, there is no advantage. I'll remove this. For some reason I assumed the logger base class wouldn't be happy being passed nil, but it's quite happy.
lib/bugsnag/loggers/logger.rb
Outdated
| require "logger" | ||
| require "bugsnag" | ||
|
|
||
| module Bugsnag::Loggers |
There was a problem hiding this comment.
Is there any benefit to the Loggers module? Bugsnag::Logger reads nicer. Is there a clash with our internal logger maybe?
There was a problem hiding this comment.
There's going to be some shared functionality between the Logger and the Appender classes (Appender coming soon). I've thought about renaming the module 'logging' as it's what the module deals with, but it will contain 'loggers', so not sure about that
|
Added the appender in with tests, I'll get some examples added, one using |
- Move logger and appender from Bugsnag::Logging to Bugsnag::Breadcrumbs module
|
This is becoming part of a separate project |
Additions
Loggercan be assigned to any interface that uses a Logger, such asActiveRecord::Base.loggerorMongoid::Loggable.loggerAppenderincludes trackableLogEventdata includingfile,line,method