Add ruby25 to TravisCI testing #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
blkperl
previously approved these changes
Oct 23, 2018
snmaynard
reviewed
Oct 23, 2018
.travis.yml
Outdated
| env: | ||
| - BUNDLE_VERSION=1.12.0 | ||
| - GEMSETS="test sidekiq coverage" | ||
| rvm: 2.5.1 |
There was a problem hiding this comment.
I think we should use 2.5 as we don't want to have to bump for patches. Similar for the other versions.
There was a problem hiding this comment.
I've updated to use patch independent versioning in all cases except for 1.9.3.
snmaynard
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Testing bugsnag against Ruby 2.5
From the PR started here