Delayed Job Tests #493
Merged
Delayed Job Tests #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent delayed job integration
|
I've taken this up, fixed the existing Maze-tests and added a couple of features to the Delayed job tests. As these tests aren't currently running on CI, reviewers should manually run the |
snmaynard
commented
Nov 3, 2018
features/delayed_job.feature
Outdated
| Given I set environment variable "BUGSNAG_API_KEY" to "a35a2a72bd230ac0aa0f52715bbdc6aa" | ||
| And I set environment variable "MAZE_API_KEY" to "a35a2a72bd230ac0aa0f52715bbdc6aa" | ||
| And I configure the bugsnag endpoint | ||
| And I generate the gem and put it in "delayed_job" |
There was a problem hiding this comment.
Ben has done this in env.rb and I think I prefer that approach. Perhaps we should look at doing the same here.
kattrali
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration tests for the delayed job integration.
I've added a step to maze to be able to build the current gem and put that into the test docker container. At the moment that invalidates the build because I'm guessing the gem contains the build time - so we need to fix that.
Once we have the framework up and running adding the rests of the tests should be easy.