Breadcrumbs feature release #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CircularBuffer class and tests
Breadcrumbs: Add Breadcrumb class
Breadcrumbs/leave breadcrumb
Breadcrumbs/Report: Make summary more accurate
Breadcrumbs: Update reports class, add Breadcrumbs middleware
Breadcrumbs: Add notify breadcrumb
…conf Breadcrumbs: Renamed auto breadcrumb types configuration name
* Breadcrumbs/Rails integration: Initial integration implemenetation * Breadcrumbs/Rails: Minor fixes * Breadcrumbs/Rails: Add initial maze tests * Breadcrumbs/Rails breadcrumbs: Remove plural event data * Breadcrumbs/Rails breadcrumbs: Ammend breadcrumb namespace * Breadcrumbs/Rails breadcrumbs: Remove event_id from allowed keys, change name to event_name * Breadcrumbs/Rails breadcrumbs: Require breadcrumb file when necessary to avoid namespace clashes * Breadcrumbs/Rails breadcrumbs: Fix rubocop issues * Breadcrumbs/Rails breadcrumbs: Clarify namespaces better * Breadcrumbs/Rails breadcrumbs: Remove invalid data from captured breadcrumb definitions * Breadcrumbs/Rails breadcrumbs: Added ActiveJob breadcrumb test * Breadcrumbs/Rails breadcrumbs: Ammended active_job event id * Breadcrumbs/Ruby breadcrumbs: Removed complex breadcrumb metadata * Breadcrumbs/Ruby: Added cache breadcrumb * Breadcrumbs/Ruby breadcrumbs: Fleshed out maze-test expectations where possible * Breadcrumbs/Rails breadcrumbs: Fixed broken test fixture, made fixtures more rails-y
* Breadcrumbs/Rails integration: Initial integration implemenetation * Breadcrumbs/Rails: Minor fixes * Breadcrumbs/Rails: Add initial maze tests * Breadcrumbs/Mongo: Initial subscriber implementation * Breadcrumbs/Rails breadcrumbs: Remove plural event data * Breadcrumbs/Rails breadcrumbs: Ammend breadcrumb namespace * Breadcrumbs/Rails breadcrumbs: Remove event_id from allowed keys, change name to event_name * Breadcrumbs/Rails breadcrumbs: Require breadcrumb file when necessary to avoid namespace clashes * Breadcrumbs/Mongo integration: Fix module name issue * Breadcrumbs/Mongo integration: Maintain consistency with ActiveSupport arguments * Breadcrumbs/Rails breadcrumbs: Fix rubocop issues * Breadcrumbs/Rails breadcrumbs: Clarify namespaces better * Breadcrumbs/Mongo integration: Add integration tests * Breadcrumbs/Mongo integration: Remove example commits * Breadcrumbs/Rails breadcrumbs: Remove invalid data from captured breadcrumb definitions * Breadcrumbs/Mongo integration: Rubocop fixes * Breadcrumbs/Mongo integration: Better doc comments * Breadcrumbs/Mongo integration: Improve tests, add 'failure' test * Breadcrumbs/Mongo integration: Re-add 'success' test * Breadcrumbs/Rails breadcrumbs: Added ActiveJob breadcrumb test * Breadcrumbs/Rails breadcrumbs: Ammended active_job event id * Breadcrumbs/Ruby breadcrumbs: Removed complex breadcrumb metadata * Breadcrumbs/Ruby: Added cache breadcrumb * Breadcrumbs/Ruby breadcrumbs: Fleshed out maze-test expectations where possible * Breadcrumbs/Mongo integration: Rubocop fixes * Breadcrumbs/Rails breadcrumbs: Fixed broken test fixture, made fixtures more rails-y * Breadcrumbs/Mongo integration: Maze fixes
…#519) * Breadcrumbs/Mongo integration: Remove 'started' event, add 'collection' data * Breadcrumbs/Mongo: Add filter keys * Breadcrumbs/Mongo integration: Made filters consistent with other breadcrumb implementations * Breadcrumbs/Mongo integration: Rubocop fixes * Breadcrumbs/Mongo integration: Address feedback
* Breadcrumbs/Rails breadcrumbs: Capture event_id * Breadcrumbs/Rails breadcrumbs: Capture 'sql' string and redacted bindings * Breadcrumbs/Rails integration: Redact SQL string values * Breadcrumbs/Rails integration: Remove SQL string acquisition * Breadcrumbs/Rails improvements: Remove unnecessary require * Breadcrumbs/Rails integration: Add integration tests for bindings * Breadcrumbs/Ruby integration: lock nokogiri version * Breadcrumbs/Ruby integration: Better meta_data naming, Ruby < 2.1 compatability
* Breadcrumbs/Mongo integration: Handle 'any_of' cases * Breadcrumbs/Mongo Integration: Improve filter sanitization process and add unit tests * Breadcrumbs/Mongo integration: Ensure tests are notated correctly * Breadcrumbs/Mongo filters: Add 1.9.3 & 2.0.0 compatability * Breadcrumbs/Mongo integration: Appease rubocop * Breadcrumbs/Mongo integration: Minor test and efficieny improvements * Breadcrumbs/Mongo integration: Test improvements * Breadcrumbs/Mongo integrations: Test spelling
…ngth until refactor)
tobyhs
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
approving now so you don't have to wait until next morning Pacific time; the build is failing in a way that is probably due to #523 and not the changes in the diff of this pull request (a re-build will likely fix it and then you can probably have a new PR to fix the non-deterministic test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Merge down full breadcrumbs feature for release.
Requires docs PR