Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky session-tracking test #526

Merged
merged 3 commits into from
Jan 22, 2019
Merged

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Jan 17, 2019

Goal

Stabilise test introduced with the auto-session-tracking feature

@Cawllec Cawllec force-pushed the fix/flaky-session-tracking-test branch from 3096c02 to bd707af Compare January 17, 2019 13:30
@Cawllec Cawllec force-pushed the fix/flaky-session-tracking-test branch from bd707af to e10daa8 Compare January 17, 2019 13:31
Copy link
Contributor

@tobyhs tobyhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -4,13 +4,6 @@
require 'json'
require 'concurrent'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also remove this line

@Cawllec Cawllec merged commit ec92f17 into master Jan 22, 2019
@imjoehaines imjoehaines deleted the fix/flaky-session-tracking-test branch June 16, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants